On 05/07/17 08:04, Wei Chen wrote:
Hi Julien,
Hi Wei,
Please avoid replying in HTML on the xen-devel.
This kind of porting error could have been mitigated if this series was
rebased as suggested multiple time on top of the fwspec work from QC
(see [1]).
Regardless that, I would much prefer to rebase this work on top of the
fwspec series. This is going to simplify a lot the logic and avoid code
duplication, arm_smmu_add_generic_master_id is very similar to
register_smmu_master.
If the fwspec work can be merged recently, I think it's good to rebase
On it.
I am not sure to understand what you mean here. It is possible to rebase
on a series without the series to be merged upstream.
Anyway, I have CCed Sameer to get a status update here.
Lastly, as I mentioned to you, any code not present in the Linux SMMU
driver should be commented with /* Xen: ... */. This is helping us to
know what has changed. For instance, I cannot find
arm_smmu_add_generic_master_id in Linux code.
Sorry about it, I forgot this comment. I will add this comment to code.
Cheers,
[1] https://lists.xen.org/archives/html/xen-devel/2017-06/msg00862.html
--
Julien Grall
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
