>>> On 03.07.17 at 10:40, <prosku...@sec.in.tum.de> wrote: > On 06/27/2017 02:04 PM, Jan Beulich wrote: >>>>> Sergej Proskurin <prosku...@sec.in.tum.de> 06/27/17 1:52 PM >>> >>> The following commits introduce a software guest page table walk >>> software implementation that supports varying guest page size >>> granularities. This commit moves already existing PAGE_SHIFT_(4K|64K) >>> and the new PAGE_SHIFT_16K defines to a common place in xen/lib.h as >>> to allow the following commits to use the consolidated defines. >> I don't think the PAGE_SHIFT_* should live far away from the other PAGE_*_* >> macros derived from them. I'm also not convinced lib.h is a good place. > > I agree. I can move related PAGE_*_* from xen/iommu.h together with > PAGE_SIZE_* macros into a common place. As we already define PAGE_* > macros in asm/config.h, I believe it would make sense to extend these by > the upper PAGE_*_* macros. What do you think? > > If you believe asm/config.h is a good place for the upper macros,
I don't, no: config.h should represent settings only, while here you define constants which aren't necessarily properties of the system the hypervisor is being built for. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
