On Thu, Jun 22, 2017 at 01:08:50PM +0530, Bhupinder Thakur wrote: [...] > static struct termios stdin_old_attr; > @@ -343,6 +344,7 @@ int main(int argc, char **argv) > char *end; > console_type type = CONSOLE_INVAL; > bool interactive = 0; > + char *console_names = "serial, pv, vuart"; > > if (isatty(STDIN_FILENO) && isatty(STDOUT_FILENO)) > interactive = 1; > @@ -361,9 +363,12 @@ int main(int argc, char **argv) > type = CONSOLE_SERIAL; > else if (!strcmp(optarg, "pv")) > type = CONSOLE_PV; > + else if (!strcmp(optarg, "vuart")) > + type = CONSOLE_VUART; > else { > fprintf(stderr, "Invalid type argument\n"); > - fprintf(stderr, "Console types supported are: > serial, pv\n"); > + fprintf(stderr, "Console types supported are: > %s\n", > + console_names);
Coding style. > exit(EINVAL); > } > break; > @@ -436,6 +441,10 @@ int main(int argc, char **argv) > else > snprintf(path, strlen(dom_path) + > strlen("/device/console/%d/tty") + 5, "%s/device/console/%d/tty", dom_path, > num); > } > + if (type == CONSOLE_VUART) { > + snprintf(path, strlen(dom_path) + strlen("/vuart/0/tty") + 1, > + "%s/vuart/0/tty", dom_path); Ditto. Fix them and: Acked-by: Wei Liu <wei.l...@citrix.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel