Konrad Rzeszutek Wilk <konrad.w...@oracle.com> writes: > On Mon, Jun 26, 2017 at 06:39:30PM +0200, Vitaly Kuznetsov wrote: >> CONFIG_BOOTPARAM_HOTPLUG_CPU0 allows to offline CPU0 but Xen HVM guests >> BUG() in xen_teardown_timer(). Remove the BUG_ON(), this is probably a >> leftover from ancient times when CPU0 hotplug was impossible, it works >> just fine for HVM. >> >> Signed-off-by: Vitaly Kuznetsov <vkuzn...@redhat.com> > > Perhaps: > > BUG_ON(cpu == 0 && xen_pv_domain()); >
Linus says no BUG_ONs :-) xen_pv_cpu_disable() has the following: if (cpu == 0) return -EBUSY; as a protection so we won't get to xen_teardown_timer() but if you think additional BUG_ON() protection is justified I'm definitely not against adding it. -- Vitaly _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel