>>> Yi Sun <yi.y....@linux.intel.com> 06/14/17 3:25 AM >>> > @@ -379,6 +414,14 @@ void psr_ctxt_switch_to(struct domain *d) > if ( psr_cmt_enabled() ) > psr_assoc_rmid(®, d->arch.psr_rmid); > > + /* If domain's 'psr_cos_ids' is NULL, we set default value for it. */ > + if ( psra->cos_mask ) > + reg = psr_assoc_cos(reg, > + (d->arch.psr_cos_ids ? > + d->arch.psr_cos_ids[cpu_to_socket(smp_processor_id())] : > + 0), > + psra->cos_mask);
The common way of indenting such longish function calls is to have the arguments be 4 positions deeper indented than the function name (following our general 4-space indentation model). Another alternative would be to use e.g. a "socket" helper variable just to shrink line length. With this taken care of either way, and preferably with the naming aspect mentioned in the previous patch also extended to here (I won't mention this again on later patches, but I'll imply it to apply there too) Reviewed-by: Jan Beulich <jbeul...@suse.com> Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel