>>> On 19.06.17 at 18:57, <julien.gr...@arm.com> wrote: > --- a/xen/include/xen/mm.h > +++ b/xen/include/xen/mm.h > @@ -56,7 +56,7 @@ > > TYPE_SAFE(unsigned long, mfn); > #define PRI_mfn "05lx" > -#define INVALID_MFN _mfn(~0UL) > +#define INVALID_MFN (mfn_t){ ~0UL }
While I don't expect anyone to wish to use a suffix expression on this constant, for maximum compatibility this should still be fully parenthesized, I think. Of course this should be easy enough to do while committing. Are you able to assure us that clang supports this gcc extension (compound literal for non-compound types), or are we going to have to see whether clang complains after having committed the change (which in turn would likely only be found later, once someone tries a non-debug build with clang)? Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel