Hi Julien, [...]
On 06/19/2017 02:45 PM, Julien Grall wrote: > Hi Sergej, > >> +/* Normalized page granule size indices. */ >> +#define GRANULE_SIZE_INDEX_4K (0) >> +#define GRANULE_SIZE_INDEX_16K (1) >> +#define GRANULE_SIZE_INDEX_64K (2) > > Why this is exported? You only use them internally. > In v2 you pointed out that it is hard to read hardcoded values. I would gladly change these changes back as I agree on this point: I also don't like having exported indices, as well. Or would you like to see these defines (and the TTBRx_VALID values beyond) directly within the guest_walk.c? >> + >> +/* Represent whether TTBR0 or TTBR1 is valid. */ >> +#define TTBR0_VALID (0) >> +#define TTBR1_VALID (1) > > Ditto. Cheers, ~Sergej _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
