On Tue, Apr 4, 2017 at 1:04 PM, Andrew Cooper <andrew.coop...@citrix.com> wrote: > On 04/04/17 14:14, Jan Beulich wrote: >> We shouldn't hand MFN info back from increase-reservation for >> translated domains, just like we don't for populate-physmap and >> memory-exchange. For full symmetry also check for a NULL guest handle >> in populate_physmap() (but note this makes no sense in >> memory_exchange(), as there the array is also an input). >> >> Signed-off-by: Jan Beulich <jbeul...@suse.com> > > Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com>
Unfortunately I just had time to do testing with this change and I have to report that introduces a critical regression for my tools. With this change in-place performing increase_reservation on a target domain no longer reports the guest frame number for external tools, thus completely breaking advanced use-cases that require this information to be able to do altp2m gfn remapping. This is a critical step in being able to introduce shadow-pages that are used to hide breakpoints and other memory modifications from the guest. If at all possible, I would like to request this change not to be part of the 4.9 release. Thanks, Tamas _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
