On Tue, 13 Jun 2017, Julien Grall wrote: > xenheap_mfn_end is storing an MFN and not a physical address. Thankfully > xenheap_mfn_end is not used in the arm64 code. So drop it.
That's fine, but in that case I would prefer to move the definition of xenheap_mfn_end under #ifdef CONFIG_ARM_32. In fact, there is another assignment of xenheap_mfn_end few lines below in the arm64 version of setup_mm: don't we need to remove that too? > Signed-off-by: Julien Grall <julien.gr...@arm.com> > --- > xen/arch/arm/setup.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c > index f00f29a45b..ab4d8e4218 100644 > --- a/xen/arch/arm/setup.c > +++ b/xen/arch/arm/setup.c > @@ -654,8 +654,6 @@ static void __init setup_mm(unsigned long dtb_paddr, > size_t dtb_size) > if ( e > bank_end ) > e = bank_end; > > - xenheap_mfn_end = e; > - > dt_unreserved_regions(s, e, init_boot_pages, 0); > s = n; > } > -- > 2.11.0 > _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
