Hi,
On 01/06/17 19:43, Andrew Cooper wrote:
On 01/06/17 18:34, Dario Faggioli wrote:
These should all be static inlines in a header file. This will avoid
forcing the compiler to insert a bunch of empty functions and have to
call them, and it allows you to modify the x86 Makefile to be
andrewcoop@andrewcoop:/local/xen.git/xen$ git diff
diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile
index 93ead6e..affeb22 100644
--- a/xen/arch/x86/Makefile
+++ b/xen/arch/x86/Makefile
@@ -59,7 +59,7 @@ obj-y += srat.o
obj-y += string.o
obj-y += sysctl.o
obj-y += time.o
-obj-y += trace.o
+obj-$(CONFIG_TRACE) += trace.o
obj-y += traps.o
obj-y += usercopy.o
obj-y += x86_emulate.o
I would use similar things for common/trace.c too. This would let the
user remove all tracing code at build time.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
