>>> On 30.05.17 at 16:05, <ross.lagerw...@citrix.com> wrote: > --- a/xen/include/asm-x86/x86_64/page.h > +++ b/xen/include/asm-x86/x86_64/page.h > @@ -28,6 +28,9 @@ > #define PADDR_MASK ((1UL << PADDR_BITS)-1) > #define VADDR_MASK ((1UL << VADDR_BITS)-1) > > +#define VADDR_TOP_BIT (1UL << (VADDR_BITS - 1)) > +#define CANONICAL_MASK (~0UL & ~((1UL << VADDR_BITS) - 1))
This is a pretty strange way to express ~VADDR_MASK. I'm not even convinced a #define is needed, the more that with 5-level page tables all these #define-s will need to become variables anyway. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
