>>> On 19.05.17 at 13:16, <anthony.per...@citrix.com> wrote:
> On Thu, May 18, 2017 at 01:32:59AM -0400, Lan Tianyu wrote:
>> --- a/include/hw/i386/apic-msidef.h
>> +++ b/include/hw/i386/apic-msidef.h
>> @@ -26,6 +26,7 @@
>>
>> #define MSI_ADDR_DEST_ID_SHIFT 12
>> #define MSI_ADDR_DEST_IDX_SHIFT 4
>> -#define MSI_ADDR_DEST_ID_MASK 0x00ffff0
>> +#define MSI_ADDR_DEST_ID_MASK 0x000fff00
>
> The value of MSI_ADDR_DEST_ID_MASK is changed here. I think the patch
> should be:
> +#define MSI_ADDR_DEST_ID_MASK 0x000ffff0
Judging from other sources, rather the other way around - the
mask needs to have further bits removed (should be 0x000ff000
afaict). Xen sources confirm this, and while Linux has the value
you suggest, that contradicts
#define MSI_ADDR_DEST_ID_SHIFT 12
#define MSI_ADDR_DEST_ID(dest) (((dest) << MSI_ADDR_DEST_ID_SHIFT) & \
MSI_ADDR_DEST_ID_MASK)
as well as
#define MSI_ADDR_EXT_DEST_ID(dest) ((dest) & 0xffffff00)
chopping off just the low 8 bits.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
