>>> On 15.05.17 at 16:10, <punit.agra...@arm.com> wrote: > --- a/xen/include/asm-x86/page.h > +++ b/xen/include/asm-x86/page.h > @@ -375,6 +375,10 @@ perms_strictly_increased(uint32_t old_flags, uint32_t > new_flags) > > #define PAGE_ALIGN(x) (((x) + PAGE_SIZE - 1) & PAGE_MASK) > > +static inline void invalidate_icache(void) > +{ > +}
This function clearly does not what its name says, so there should be a brief comment saying why. Everything else looks reasonable. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel