Wei Liu writes ("Re: [PATCH for-4.9] build: stubdom and tools should depend on public header target"): > On Wed, May 17, 2017 at 02:16:39PM +0100, Ian Jackson wrote: > > The new code in the Makefiles LGTM. I have only one nit, which is > > that style for Makefile targets seems to be to use `-' rather than `_' > > as a word separator. > > IIRC at one point I used '-' in mini-os build system but some version of > make didn't like it. So I stick with '_' since.
I think you are confused. You are probably thinking of variable names which cannot contain -. (Well, which are troublesome if they do.) As you can see, our Makefiles are full of target names containing -. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel