On Fri, 2015-01-30 at 18:49 +0000, Julien Grall wrote: Subject: "devices"
> Xen is currently using list a compatible string to know if the driver "using a list of compatible strings" rather than "if the driver can use device node" I'd say something like "to match drivers against device nodes". > can use device node. This leads to have double definition in the GIC > code. "having double definitions". (aside: can we eventually get rid of that duplication somehow?) > Futhermore Linux drivers is using dt_match_node (actually called of_device_id "Furthermore" and "are using" > in Linux) to list device supported by the drivers. "devices" I'd append one more sentence, something like "Remove the existing compatible field and replace with a dt_match field". Just to make it clear what the change here is. > > Signed-off-by: Julien Grall <julien.gr...@linaro.org> > Acked-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> The actual code looks fine, with the commit message fixed up as described: Acked-by: Ian Campbell <ian.campb...@citrix.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
