On Thu, 11 May 2017, Paolo Bonzini wrote:
> On 09/05/2017 21:04, Stefano Stabellini wrote:
> > Assert that the return value is not an error. This issue was found by
> > Coverity.
> >
> > CID: 1374831
> >
> > Signed-off-by: Stefano Stabellini <sstabell...@kernel.org>
> > CC: gr...@kaod.org
> > CC: pbonz...@redhat.com
> > CC: Eric Blake <ebl...@redhat.com>
>
> Queued, thanks.
I am about to send a pull request with the rest of the series, but I'll
leave this one to you.
Cheers,
Stefano
> > ---
> > util/oslib-posix.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/util/oslib-posix.c b/util/oslib-posix.c
> > index 4d9189e..16894ad 100644
> > --- a/util/oslib-posix.c
> > +++ b/util/oslib-posix.c
> > @@ -182,7 +182,9 @@ void qemu_set_cloexec(int fd)
> > {
> > int f;
> > f = fcntl(fd, F_GETFD);
> > - fcntl(fd, F_SETFD, f | FD_CLOEXEC);
> > + assert(f != -1);
> > + f = fcntl(fd, F_SETFD, f | FD_CLOEXEC);
> > + assert(f != -1);
> > }
> >
> > /*
> >
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
