On 03/05/17 09:55, Jan Beulich wrote: >>>> On 02.05.17 at 20:05, <andrew.coop...@citrix.com> wrote: >> --- a/xen/arch/x86/traps.c >> +++ b/xen/arch/x86/traps.c >> @@ -3872,7 +3872,7 @@ void __init trap_init(void) >> >> /* The 32-on-64 hypercall vector is only accessible from ring 1. */ >> _set_gate(idt_table + HYPERCALL_VECTOR, >> - SYS_DESC_trap_gate, 1, &compat_hypercall); >> + SYS_DESC_trap_gate, 1, &entry_int82); > Would you mind at once dropping the unnecessary & ?
Fixed. > >> --- a/xen/include/asm-x86/processor.h >> +++ b/xen/include/asm-x86/processor.h >> @@ -529,6 +529,8 @@ DECLARE_TRAP_HANDLER(simd_coprocessor_error); >> DECLARE_TRAP_HANDLER_CONST(machine_check); >> DECLARE_TRAP_HANDLER(alignment_check); >> >> +DECLARE_TRAP_HANDLER(entry_int82); > This is inappropriate, I think: There's no do_entry_int82. With this > changed to a simply void entry_int82(void) declaration > > Reviewed-by: Jan Beulich <jbeul...@suse.com> I hadn't even realised I had split the introduction of the two functions across two patches, but I'd prefer to keep them split like this and I will ensure that this gets committed at the same time as the following patch. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
