On 05/02/2017 07:11 PM, Andrew Cooper wrote: > On 02/05/17 17:02, Tim Deegan wrote: >> At 18:21 +0300 on 02 May (1493749307), Razvan Cojocaru wrote: >>> hvm_save_cpu_ctxt() returns success without writing any data into >>> hvm_domain_context_t when all VCPUs are offline. This can then crash >>> the hypervisor (with FATAL PAGE FAULT) in hvm_save_one() via the >>> "off < (ctxt.cur - sizeof(*desc))" for() test, where ctxt.cur remains 0, >>> causing an underflow which leads the hypervisor to go off the end of the >>> ctxt buffer. >> [...] >>> Reported-by: Razvan Cojocaru <rcojoc...@bitdefender.com> >>> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> >>> Signed-off-by: Razvan Cojocaru <rcojoc...@bitdefender.com> >>> Tested-by: Razvan Cojocaru <rcojoc...@bitdefender.com> >> I actually preferred the first patch > > As did I. Seeing as there is no more of my code in it, you should > probably drop my SoB, but this can be fixed up on commit if there are no > other issues.
Hah, I've just replied that you should be the author. :) I am fine with however you prefer this to go. Thanks, Razvan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
