>>> On 25.04.17 at 16:52, <andrew.coop...@citrix.com> wrote: > On 25/04/17 14:52, Wei Liu wrote: >> - fail: >> - pv_domain_destroy(d); >> - >> - return rc; >> -} >> - >> +void paravirt_ctxt_switch_from(struct vcpu *v); >> +void paravirt_ctxt_switch_to(struct vcpu *v); >> int arch_domain_create(struct domain *d, unsigned int domcr_flags, >> struct xen_arch_domainconfig *config) >> { >> @@ -1919,7 +1717,8 @@ static void save_segments(struct vcpu *v) >> >> #define switch_kernel_stack(v) ((void)0) >> >> -static void paravirt_ctxt_switch_from(struct vcpu *v) >> +/* Needed by PV guests */ >> +void paravirt_ctxt_switch_from(struct vcpu *v) >> { > > Could these be moved up to avoid the forward declarations above?
Moved up? I don't see why they're not simply being moved to pv/domain.c and kept static there (suitably placed so that the forward declarations don't need to be retained). As their names say, they're very PV-specific... Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel