On Mon, Apr 24, 2017 at 06:39:38AM -0600, Jan Beulich wrote: > >>> On 10.04.17 at 15:27, <wei.l...@citrix.com> wrote: > > Move all the PV specific code along with the supporting code to > > pv/domain.c. > > Had you done this series in a different order, or had the earlier > patches moved their broken out functions right away, this patch > would have been quite a bit smaller. Anyways, it looks to be pure
It is just trading one kind of code churn for another. For example, free_compact_l4 is used by several PV functions. Should I choose to move those PV functions (pv_vcpu_initialise and _destroy) as I go along I will then need to export these static helper functions while I am doing it then unexport them when I am finished. I am not too fuss either way in this particular series. I am inclined to move everything in one or more patches when the refactoring is done. But please let me know if you feel strongly about how it should be done. Wei. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
