On Thu, 2017-04-13 at 10:42 +0100, Julien Grall wrote: > Hi Dario, > > On 13/04/17 08:49, Dario Faggioli wrote: > > Since the counter is unsigned, it's pointless/bogous to check > > for if to be above zero. > > > > Check that it is at least one before it's decremented, instead. > > > > Spotted by Coverity. > > Do you have the Coverity-ID? :) > This comes from the Citrix internal instance, so the ID wouldn't make any sense.
I don't know if the XenProject instance has also caught it. I guess it's likely, but I don't have access, so I can't check. Adding the above line is what Andrew suggested doing (saying he does it himself) when things like this happens, to better reflect the reality. Let me know if I should do anything different (of feel free to add or change anything related to this upon commit). Regards, Dario -- <<This happens because I choose it to happen!>> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
