On 17-04-11 09:25:28, Jan Beulich wrote:
> >>> On 01.04.17 at 15:53, <yi.y....@linux.intel.com> wrote:
> > +static void do_write_psr_msr(void *data)
> > +{
> > + struct cos_write_info *info = data;
> > + unsigned int cos = info->cos;
> > + struct feat_node *feat = info->feature;
> > +
> > + if ( cos > feat->props->cos_max )
> > + return;
>
> This check can as well be done in the caller, allowing to avoid the IPI
> in case it's true.
>
Yes, thanks!
> > + feat->props->write_msr(cos, info->val, feat);
>
> Once the function consists of just this I wonder if it wasn't better
> to invoke the hook directly from write_psr_msr().
>
To solve the issue we discussed in patch 5, I propsed a solution which may
change here. If you agree that solution, I think we still need this helper
function.
> Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
