On Thu, Apr 06, 2017 at 05:32:32PM +0100, Ian Jackson wrote:
> Anthony PERARD writes ("[OSSTEST PATCH v9 1/3] ts-openstack-deploy: Deploy
> OpenStack on a host with devstack"):
> > This script installs any necessary packages and clones all of the OpenStack
> > trees which are used by devstack to deploy OpenStack.
> >
> > Signed-off-by: Anthony PERARD <anthony.per...@citrix.com>
> > Acked-by: Ian Jackson <ian.jack...@eu.citrix.com>
>
> I found in one of my working trees this diff to this patch:
>
> > +sub deploy() {
> > + target_cmd($ho, <<END, 1800);
> > + cd $builddir/devstack
> > + ./stack.sh
> > +END
>
> diff --git a/ts-openstack-deploy b/ts-openstack-deploy
> index 6542da8..85197b0 100755
> --- a/ts-openstack-deploy
> +++ b/ts-openstack-deploy
> @@ -127,6 +127,7 @@ END
>
> sub deploy() {
> target_cmd($ho, <<END, 1800);
> + set -e
> cd $builddir/devstack
> ./stack.sh
> END
>
> Who currently has custody of this branch ? I think I would like you
> to take it back and fold this change in. When I've sorted out the
> https proxy certificate issue, I'll ask you to rebase onto current
> osstest master.
>
> Also, it would be worth grepping for other occurrences of target_cmd
> with missing set -e. (target_cmd_build implies set -e.)
>
> Would that be OK ?
Yes, that's OK. I'll add the `set -e`s in my branch.
I guess 'target_cmd_root' needs the same treatment.
--
Anthony PERARD
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
