>>> On 06.04.17 at 10:45, <julien.gr...@arm.com> wrote: > (CC 'The REST' maintainers) > > Hi, > > Andre, as I mentioned already a couple of times. You should CC all the > appropriate maintainers for the code you are modifying. > > On 06/04/17 00:25, Stefano Stabellini wrote: >> On Thu, 6 Apr 2017, Andre Przywara wrote: >>> To safely handle 64-bit registers even on 32-bit systems, introduce >>> a GENMASK_ULL variant (lifted from Linux). >>> This adds a BITS_PER_LONG_LONG define as well. >>> Also fix a bug in the comment for the existing GENMASK variant. >>> >>> Signed-off-by: Andre Przywara <andre.przyw...@arm.com> >> >> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> > > I'd like some input from Andrew here. I suggested a similar patch a year > ago (see [1]) and the final decision was to drop GENMASK_ULL.
Well, to be honest, rather than asking Andrew (who would likely just re-state his opinion, as I would re-state mine), it should be Andre to make clear why things are different now than they were when the introduction of the macro was first rejected. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
