On Fri, Feb 13, 2015 at 03:49:44PM +0000, Andrew Cooper wrote:
[...]
> >
> > +
> > +int libxl__vnuma_build_vmemrange_pv_generic(libxl__gc *gc,
> > + uint32_t domid,
> > + libxl_domain_build_info
> > *b_info,
> > + libxl__domain_build_state
> > *state)
> > +{
> > + int i;
> > + uint64_t next;
> > + xen_vmemrange_t *v = NULL;
> > +
> > + /* Generate one vmemrange for each virtual node. */
> > + GCREALLOC_ARRAY(v, b_info->num_vnuma_nodes);
> > + next = 0;
> > + for (i = 0; i < b_info->num_vnuma_nodes; i++) {
> > + libxl_vnode_info *p = &b_info->vnuma_nodes[i];
> > +
> > + v[i].start = next;
> > + v[i].end = next + (p->memkb << 10);
> > + v[i].flags = 0;
> > + v[i].nid = i;
> > +
> > + next = v[i].end;
>
> Using "start" and "end", this would appear to have a fencepost error
> which a start/size pair wouldn't have.
>
Are you suggesting I change to use "start" and "size"? If so I don't
think that's possible. xen_vmemrange_t is part of the hypervisor
interface.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
