Hi, On 22/03/17 16:33, Julien Grall wrote: [ ... ] >>>> gicv3_dist_init(); >>>> + res = gicv3_its_init(); >>>> + if ( res ) >>>> + printk(XENLOG_WARNING "GICv3: ITS: initialization failed: >>>> %d\n", res); >>> >>> I would have expect a panic here because the ITS subsystem could be half >>> initialized and it is not safe to continue. >> >> OK, let me check what actually happens here if there is no ITS ;-) > > Technically, this message should not happen when there is no ITS because > it is not mandatory to have one on the platform. > > So this would be an coding error for me.
Having no ITS (node in the DT) would result in a empty host_its_list and a "0" return, so doesn't raise any issues. Technically we could cope with one or all ITSes to not initialize (by not propagating them to any guests). But for now I can just panic here, I guess, because it should point to some serious issue. If there is a use case, we can always add a more relaxed behavior later. Cheers, Andre. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
