> -----Original Message----- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 22 March 2017 11:38 > To: Paul Durrant <paul.durr...@citrix.com> > Cc: Andrew Cooper <andrew.coop...@citrix.com>; Ian Jackson > <ian.jack...@citrix.com>; xen-de...@lists.xenproject.org > Subject: Re: [Xen-devel] [PATCH v3 6/6] x86/viridian: implement the crash > MSRs > > >>> On 21.03.17 at 19:17, <paul.durr...@citrix.com> wrote: > > + case HV_X64_MSR_CRASH_CTL: > > + { > > + HV_CRASH_CTL_REG_CONTENTS ctl = { > > + .CrashNotify = 1, > > + }; > > This initializer failed my pre-push build test: Some gcc versions we > still support don't allow fields of unnamed union members to be > initialized this way. As there are at least two ways to deal with > this, and as this is code maintained by you, I didn't want to pick > either, as I don't know your preference. >
Ok, I guess I'll go for naming the union member. Do you want me to resubmit? Paul > Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
