On Tue, Mar 21, 2017 at 05:14:47PM +0000, Wei Liu wrote: > On Mon, Mar 20, 2017 at 09:00:20AM +0100, Juergen Gross wrote: > > When the number of permitted xenstore entries for a domain is being > > exceeded the operation trying to create a new entry is denied. > > Unfortunately errno isn't being set in this case so the error code > > returned to the client is undefined. > > > > Set errno to ENOSPC in this case. > > > > Signed-off-by: Juergen Gross <jgr...@suse.com> > > Acked-by: Wei Liu <wei.l...@citrix.com> > > But ... > > > --- > > This is a backport candidate. > > --- > > tools/xenstore/xenstored_core.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/tools/xenstore/xenstored_core.c > > b/tools/xenstore/xenstored_core.c > > index 5c659d8..ed80345 100644 > > --- a/tools/xenstore/xenstored_core.c > > +++ b/tools/xenstore/xenstored_core.c > > @@ -937,8 +937,10 @@ static struct node *construct_node(struct connection > > *conn, const void *ctx, > > if (!parent) > > return NULL; > > What about this and other places?
Oh, this relies on errno being set in some other place(s). This is really poor error handling style... :-/ Wei. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
