2017-03-21 23:22 GMT+08:00 Jan Beulich <jbeul...@suse.com>: >>>> On 21.03.17 at 15:56, <blacksk...@gmail.com> wrote: >> 2017-03-21 22:27 GMT+08:00 Jan Beulich <jbeul...@suse.com>: >>>>>> On 21.03.17 at 12:18, <blacksk...@gmail.com> wrote: >>>> --- a/xen/common/Kconfig >>>> +++ b/xen/common/Kconfig >>>> @@ -237,4 +237,26 @@ config FAST_SYMBOL_LOOKUP >>>> The only user of this is Live patching. >>>> >>>> If unsure, say Y. >>>> + >>>> +config CMDLINE >>>> + string "Built-in hypervisor command string" >>>> + default "" >>>> + depends on EXPERT = "y" >>> >>> Luckily I've noticed the non-EXPERT build failure in my pre-push >>> tests: During review of patch 3 I had asked for converting the >>> "depends on" into a conditional prompt, and I don't see why >>> this wasn't done. Did you ever do a non-EXPERT build with your >>> patch? >>> >> Yes, I've built and tested my patch with and without XEN_CONFIG_EXPERT=y. >> Could you please show me the error message? > > The error I've got was that CONFIG_CMDLINE was undefined in > xen/common/kernel.c, which isn't really surprising with the option > having had a "depends on", but the use being unconditional. > After doing a full clean and making it again. I got the same error message. This seems to be a huge mistake. I've now changed the "depends on" into a conditional prompt, and have done both EXPERT and non-EXPERT build again (with a full clean every time before building). So this time it shouldn't report this error again. But anyway, please do test it out again.
Cheers. Zhongze Liu. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
