> -----Original Message----- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 21 March 2017 15:27 > To: Paul Durrant <paul.durr...@citrix.com> > Cc: Andrew Cooper <andrew.coop...@citrix.com>; xen- > de...@lists.xenproject.org > Subject: Re: [PATCH v2 1/6] x86/viridian: fix xen-hvmcrash when vp_assist > page is present > > >>> On 20.03.17 at 18:08, <paul.durr...@citrix.com> wrote: > > Currently use of xen-hvmcrash will cause an immediate domain_crash() in > > initialize_vp_assist() because it is called from viridian_load_vcpu_ctxt() > > without having first cleared any previous mapping. > > > > This patch addes a check into viridian_load_vcpu_ctxt() to avoid re- > > initialization and turned the domain_crash() in initialize_vp_assist() > > into an ASSERT() since neither codepath into that function should allow > > it to be hit. > > The patch looks fine to me, but not in line with the description: > There's no domain_crash() being eliminated anymore.
Oh. That hunk must have been dropped for some reason. It should be there. I'll send v3. Paul > > Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
