On 13/02/15 15:05, Wei Liu wrote: > On Fri, Feb 13, 2015 at 02:30:30PM +0000, Andrew Cooper wrote: >> On 12/02/15 19:44, Wei Liu wrote: >>> diff --git a/tools/libxc/xc_private.h b/tools/libxc/xc_private.h >>> index 45b8644..1809674 100644 >>> --- a/tools/libxc/xc_private.h >>> +++ b/tools/libxc/xc_private.h >>> @@ -35,6 +35,8 @@ >>> >>> #include <xen/sys/privcmd.h> >>> >>> +#define XC_VNUMA_NO_NODE (~0U) >> Shouldn't this sentinel value come from the Xen public API? >> > Xen public headers don't have a NUMA_NO_NODE though. Do you want me > to add one to memory.h?
Yes please. There are far too many sentinel values missing in the Xen public API which libxc has a different #define for (INVALID_MFN being the main one). Best not to make the situation any worse. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
