> -----Original Message----- > From: Ian Jackson [mailto:ian.jack...@eu.citrix.com] > Sent: Wednesday, February 11, 2015 10:59 PM > To: Hu, Robert > Cc: xen-devel@lists.xen.org; ian.jack...@eu.citrix.com; jfeh...@suse.com; > wei.l...@citrix.com; ian.campb...@citrix.com; Pang, LongtaoX > Subject: Re: [PATCH OSSTEST 06/12] Manipulate $ho IP assignment for nest L2 > situation > > Robert Ho writes ("[PATCH OSSTEST 06/12] Manipulate $ho IP assignment for > nest L2 situation"): > > In L2 installation context, its host (L1) IP address is not queried > > from DNS, but from previous step of L1 installation, in which, L1 IP > > is stored in run var. > > > - $ho->{IpStatic} = get_host_property($ho,'ip-addr'); > > + if ($name eq 'nested') { > > This is definitely the wrong test. > > It would be easier to read this series if you introduced the framework > first, and then applied all the specific differences afterwards. > > Instead of keying off $name I think you probably need to make a > variant of selecthost that takes an existing guest ($gho) and converts > it into a useable host ($ho). > > It would probably be necessary to split out the bulk of the existing > selecthost into a core function. > > I think you also want a general way to specify how the L1's host > properties are set. Good point! This is indeed my missing point, will fix this. I didn't get the idea of host property in previous code reading. Where can I get the idea of what 'host property' is? how it is supposed to use? Any text I can find introducing it? Or you can give a little hint on it? thanks. > > Ian.
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
