On 10/02/15 08:52, Jan Beulich wrote: >>>> On 09.02.15 at 21:04, <boris.ostrov...@oracle.com> wrote: >> * Make changes to xen_sysctl_numainfo, similar to those made to >> xen_sysctl_topologyinfo. (Q: I kept both sets of changes in the same >> patch #3 to avoid bumping interface version twice. Perhaps it's better >> to split it into two?) > There's no need to bump it more than once between releases. > Hence yes - splitting would be better.
I will wait until patch 3 is split to do an in-depth review, but one thing you need to fix is that the INVALID_$FOO identifiers need a XEN_ prefix to put them in the same namespace as the other identifiers. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
