On Wed, Feb 4, 2015 at 10:49 AM, Jan Beulich <jbeul...@suse.com> wrote: >>>> On 29.01.15 at 22:46, <tamas.leng...@zentific.com> wrote: >> The flag is only used for debugging purposes, thus it should be only checked >> for in debug builds of Xen. > > So this should be where the respective conditional I just complained > about should get added. > > >> --- a/xen/common/mem_access.c >> +++ b/xen/common/mem_access.c >> @@ -30,6 +30,37 @@ >> #include <asm/p2m.h> >> #include <xsm/xsm.h> >> >> +void mem_access_resume(struct domain *d) >> +{ > > Why is this being re-added, and how do things build with the other > (inline) mem_access_resume() added in an earlier patch? > > Jan
Yes, this patch got a bit mixed up with the previous one. To answer your question nevertheless, mem_access_resume is redefined to be only doing mem_access related work. Previously it was responsible to pulling all the responses off the ring, even if these were not mem_access related. Now the monitor is pulling the responses off the ring, and issues mem_access_resume if the response is to a mem_access request. Tamas _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel