Hi Ian, On 30/01/15 11:30, Ian Campbell wrote: > On Thu, 2015-01-29 at 18:32 +0000, Julien Grall wrote: >> Hello, >> >> Ping? Any more review for this version of this series? > > I was awaiting a version with the declarations in the right places as > pointed out by Andy (including his point about definition vs. prototype > I'm afraid, which is the style we use).
I'm not convince about your last point. We have many places (if not all on ARM) where __init is used in the header. Some of them was even added by you ;). So I would prefer if we keep them, it's more readable. FWIW Linux does it too. Regards, -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
