On 01/28/15 17:04, Ard Biesheuvel wrote: > On 28 January 2015 at 15:04, Olivier Martin <olivier.mar...@arm.com> wrote: >> I do not have a strong opinion on this patch. >> It would be better to keep the dynamic PCD support in this patch. But I am >> aware it is not possible with PrePi (I had the issue a couple of weeks ago). >> Dynamic Pcds are actually supported when you use the PeiCore with PcdPeim. >> But the PeiCore only make sense at the moment on platforms that have DRAM >> initialized by the UEFI firmware. >> I would like to extend the PI spec to also be able to use PeiCore in the >> case where the DRAM is already initialized at the time of the UEFI firmware. >> That would mean we could use the PcdPeim and Dynamic Pcd. But it will take >> time before we have support for it. >> And I do not want to gate the patch set for this reason. >> > > OK. > >> I am ok to accept it if no one reject it. >> >> >> Anyway, this patch breaks the ARM Toolchain build: >> >> "armlink" --partial -o >> /tianocore/Build/ArmVirtualizationQemu-ARM/DEBUG_RVCTLINUX/ARM/ArmPlatformPk >> g/PrePeiCore/PrePeiCoreUniCore/OUTPUT/ArmPlatformPrePeiCore.lib --via >> /tianocore/Build/ArmVirtualizationQemu-ARM/DEBUG_RVCTLINUX/ARM/ArmPlatformPk >> g/PrePeiCore/PrePeiCoreUniCore/OUTPUT/object_files.lst >> "armlink" --ro-base 0 --no_scanlib --reloc --no_exceptions --datacompressor >> off --strict --symbols --diag_style=ide --entry _ModuleEntryPoint --map >> --list >> /tianocore/Build/ArmVirtualizationQemu-ARM/DEBUG_RVCTLINUX/ARM/ArmPlatformPk >> g/PrePeiCore/PrePeiCoreUniCore/DEBUG/ArmPlatformPrePeiCore.map -o >> /tianocore/Build/ArmVirtualizationQemu-ARM/DEBUG_RVCTLINUX/ARM/ArmPlatformPk >> g/PrePeiCore/PrePeiCoreUniCore/DEBUG/ArmPlatformPrePeiCore.dll --via >> /tianocore/Build/ArmVirtualizationQemu-ARM/DEBUG_RVCTLINUX/ARM/ArmPlatformPk >> g/PrePeiCore/PrePeiCoreUniCore/OUTPUT/static_library_files.lst >> armlink : error L6218: Undefined symbol AllocatePages (referred from >> ArmVirtualizationPlatformLib.lib). >> armlink : Not enough information to list image symbols. >> armlink : Finished: 1 information, 0 warning and 1 error messages. >> > > Probably just a missing MemoryAllocationLib dependency in > ArmVirtualizationPlatformLib.inf
If you fix that in the next version, you can add Reviewed-by: Laszlo Ersek <ler...@redhat.com> Thanks! Laszlo _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
