>>> On 29.01.15 at 18:34, <t...@xen.org> wrote: > At 11:10 +0000 on 28 Jan (1422439811), Andrew Cooper wrote: >> On 28/01/15 08:11, Jan Beulich wrote: >> > --- a/xen/arch/x86/mm/shadow/Makefile >> > +++ b/xen/arch/x86/mm/shadow/Makefile >> > @@ -1,4 +1,5 @@ >> > -obj-$(x86_64) += common.o guest_2.o guest_3.o guest_4.o >> > +obj-y := none.o >> > +obj-$(shadow-paging) := common.o guest_2.o guest_3.o guest_4.o >> > >> >> Can this be >> >> ifeq($(shadow-paging),y) >> obj-y := common.o guest_2.o guest_3.o guest_4.o >> else >> obj-y := none.o >> endif >> >> Rather than relying on the double := to clobber none.o and prevent a >> link failure ? > > +1 to this too, for readability.
As you both ask for it I'll do it, but very reluctantly, as to me this makes it worse to read, not better. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
