Hi Oleksandr, On 27/01/15 13:39, Oleksandr Tyshchenko wrote: > -/* Set up the timer on the boot CPU */ > -int __init init_xen_time(void) > +static const struct dt_device_match timer_ids[] __initconst = > +{ > + DT_MATCH_TIMER, > + { /* sentinel */ }, > +}; > + > +/* Set up the timer on the boot CPU (early init function) */ > +void __init preinit_xen_time(void) > { > - static const struct dt_device_match timer_ids[] __initconst = > - { > - DT_MATCH_TIMER, > - { /* sentinel */ }, > - };
I guess this is a left-over from the previous version? I would keep the definition of the variable here. Otherwise this patch looks good to me. Regards, -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel