On Sun, 2015-01-25 at 15:38 +0000, Wei Liu wrote:
> In d9740237a ("tools: unhook blktap1 from the build and remove all
> references to it"), one spot was left unchanged, which leads to failure
> in building qemu-xen-traditional.Well spotted, which make invocation hits this path? make dist (what I test) didn't. > Signed-off-by: Wei Liu <wei.l...@citrix.com> > Cc: Ian Campbell <ian.campb...@citrix.com> > Cc: Ian Jackson <ian.jack...@eu.citrix.com> Acked-by: Ian Campbell <ian.campb...@citrix.com> Should we be worried that the -all- and -install- targets are similar but not identical? Specifically one of them lack --extra-cflags? Perhaps we should refactor those so the options are only given ones? > --- > tools/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/Makefile b/tools/Makefile > index 1ad7a5d..5d7a75f 100644 > --- a/tools/Makefile > +++ b/tools/Makefile > @@ -158,6 +158,7 @@ qemu-xen-traditional-dir-force-update: > qemu-xen-traditional-dir-find > subdir-all-qemu-xen-traditional-dir: qemu-xen-traditional-dir-find > set -e; \ > $(buildmakevars2shellvars); \ > + export CONFIG_BLKTAP1=n; \ > cd qemu-xen-traditional-dir; \ > $(QEMU_ROOT)/xen-setup \ > $(IOEMU_EXTRA_LDFLAGS) \ _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
