On Thu, Jan 22, 2015 at 5:32 PM, Andrew Cooper <andrew.coop...@citrix.com> wrote: > On 18/01/15 15:18, Tamas K Lengyel wrote: >> -void hvm_event_cr0(unsigned long value, unsigned long old) >> -{ >> - vm_event_request_t req = { >> - .reason = VM_EVENT_REASON_CR0, >> - .vcpu_id = current->vcpu_id, >> - .cr_event.new_value = value, >> - .cr_event.old_value = old >> - }; >> - >> - long parameters = current->domain->arch.hvm_domain >> - .params[HVM_PARAM_MEMORY_EVENT_CR0]; > > (I realise this is probably not the best patch, but) As we are redoing > the API with a hope of including PV and ARM guests, can we remove this > use of hvm params? This would probably involve a new setup hypercall > subop to set up reporting preferences. > > ~Andrew
Ack, that would be certainly a useful addition. We would need to define some new place to store these preferences for the domain. Thanks, Tamas _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel