Ian Campbell writes ("[PATCH OSSTEST v2 06/18] TestSupport: always use xl for
generic operations."):
> For several operations in TestSupport.pm the actual toolstack isn't really
> relevant, since we want info straight from Xen. For simplicity just use xl (or
> xm) in these cases, to avoid needing to implement the following specially for
> each toolstack:
...
> +sub common_toolstack () {
> + my $tsname= $r{toolstack} || 'xend';
> + my $ts = 'xl';
> + $ts = 'xm' if $tsname eq 'xend';
> + return $ts;
> +}
Shouldn't this look this up in the host ? I can imagine scenarios
where we have multiple toolstacks at different times or on different
hosts (eg, to test upgrades or sidegrades).
So I think common_toolstack at the very least should take a $ho.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
