At 13:43 -0800 on 16 Jan (1421412191), Ed White wrote: > I've tried to make all my work consistent with existing code > and design in the same vein or same source file, regardless of my > opinion of that existing content, unless I had some compelling reason > not to. I've also tried not to touch anything that I didn't absolutely > have to touch (and as I've hinted, I'm not allowed to touch nested p2m). > > I'm sure I haven't always succeeded, but that has been my intent. > My view was that this approach gave me the best chance of getting > the work accepted.
Thank you for that, by the way. I realise that this kind of review can be terribly off-putting because every negative thing has to be gone over in detail whereas the positives are pretty well taken for granted. And there is basically no way to get everything right first time through -- you'll see that even code from long-time contributors goes through the same process. Cheers, Tim. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
