Hi Wei, On 09/01/15 14:15, Wei Liu wrote: > On Fri, Jan 09, 2015 at 01:54:22PM +0000, Julien Grall wrote: >> If we fail to give the access, the domain will unlikely work correctly. >> So we should bail out at the first error. >> >> Signed-off-by: Julien Grall <julien.gr...@linaro.org> >> Cc: Ian Jackson <ian.jack...@eu.citrix.com> >> Cc: Stefano Stabellini <stefano.stabell...@eu.citrix.com> >> Cc: Ian Campbell <ian.campb...@citrix.com> >> Cc: Wei Liu <wei.l...@citrix.com> >> >> --- >> This patch is candidate for a backport for at least Xen 4.4 and Xen 4.5. > > The handling of io mem has same issue. You may also want to fix that?
I forgot this one. I will fix in the next version. > Also do you need to clean up (revoke permission) the ports, irqs and io > mems that have already been assigned? We don't need to clean up ioport/irqs/iomems. It's already done implicitly when the domain is destroyed. > I presume that's done when domain > is destroyed? If domain destroyed doesn't correctly revoke the permission that would mean the code is buggy in the normal behavior. Regards, -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
