On Wed, 2014-12-10 at 12:13 -0500, Konrad Rzeszutek Wilk wrote: > On Tue, Dec 09, 2014 at 04:43:22PM +0000, Andrew Cooper wrote: > > The error handling from a failed memory allocation should return > > PyErr_SetFromErrno(xc_error_obj); rather than simply calling it and > > continuing > > to the memcpy() below, with the dest pointer being NULL. > > > > Coverity also complains about passing a non-NUL terminated string to > > xc_flask_context_to_sid(). xc_flask_context_to_sid() doesn't actually take > > a > > NUL terminated string, but it does take a char* which, in context, used to > > be > > a string, which is why Coverity complains. > > > > One solution would be to use strdup(ctx) which is simpler than a > > strlen()/malloc()/memcpy() combo, which would result in a NUL-terminated > > string being used with xc_flask_context_to_sid(). > > > > However, ctx is strictly an input to the hypercall and is not mutated along > > the way. Both these issues can be fixed, and the error logic simplified, by > > not duplicating ctx in the first place. > > > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > > Coverity-IDs: 1055305 1055721 > > Acked-by: Ian Campbell <ian.campb...@citrix.com> > > CC: Ian Jackson <ian.jack...@eu.citrix.com> > > CC: Wei Liu <wei.l...@citrix.com> > > CC: Xen Coverity Team <cover...@xen.org> > > > > --- > > v2: Expand the commit message. No code change > > Thank you. > > Release-Acked-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> >
Applied. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
