On 11/12/14 18:04, Juergen Gross wrote: > Instead of manually list each hypercall in arch/x86/xen/xen-head.S > use the auto generated symbol list. > > This also corrects the wrong address of xen_hypercall_mca which was > located 32 bytes higher than it should. > > Symbol addresses have been verified to match the correct ones via > objdump output. [...] > + > +#define HYPERCALL(n) \ > + .equ xen_hypercall_##n, hypercall_page + __HYPERVISOR_##n * 32; \ > + .type xen_hypercall_##n, function; .size xen_hypercall_##n, 32 > +#include <asm/xen-hypercalls.h> > +#undef HYPERCALL
The gas manual[1] suggests the syntax you've used for .type is invalid and suggest using .type <name>, STT_FUNC > + > .balign PAGE_SIZE You can remove this .balign. David [1] https://sourceware.org/binutils/docs/as/Type.html#Type _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
