On 08/12/14 00:19, Mihai Donțu wrote:
> Both __warn() and __bug() take as first parameter the file name of the
> current compilation unit (__FILE__). Mark that parameter as constant to
> better reflect that.
>
> Signed-off-by: Mihai Donțu <mdo...@bitdefender.com>
This seems reasonable, but for 4.6 at this point.
Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com>
In future, please CC the relevant maintainers (scrips/get_maintainer.pl
should help)
> ---
> xen/drivers/char/console.c | 4 ++--
> xen/include/xen/lib.h | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c
> index 2f03259..7807cf2 100644
> --- a/xen/drivers/char/console.c
> +++ b/xen/drivers/char/console.c
> @@ -1138,7 +1138,7 @@ void panic(const char *fmt, ...)
> machine_restart(5000);
> }
>
> -void __bug(char *file, int line)
> +void __bug(const char *file, int line)
> {
> console_start_sync();
> printk("Xen BUG at %s:%d\n", file, line);
> @@ -1146,7 +1146,7 @@ void __bug(char *file, int line)
> panic("Xen BUG at %s:%d", file, line);
> }
>
> -void __warn(char *file, int line)
> +void __warn(const char *file, int line)
> {
> printk("Xen WARN at %s:%d\n", file, line);
> dump_execution_state();
> diff --git a/xen/include/xen/lib.h b/xen/include/xen/lib.h
> index f11b49e..8f9cadb 100644
> --- a/xen/include/xen/lib.h
> +++ b/xen/include/xen/lib.h
> @@ -8,8 +8,8 @@
> #include <xen/string.h>
> #include <asm/bug.h>
>
> -void noreturn __bug(char *file, int line);
> -void __warn(char *file, int line);
> +void noreturn __bug(const char *file, int line);
> +void __warn(const char *file, int line);
>
> #define BUG_ON(p) do { if (unlikely(p)) BUG(); } while (0)
> #define WARN_ON(p) do { if (unlikely(p)) WARN(); } while (0)
> --
> 2.2.0
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
