> From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Thursday, December 04, 2014 11:33 PM > > + if ( pcidevs == NULL ) > > + { > > + rcu_unlock_domain(d); > > + return -ENOMEM; > > + } > > + > > + if ( copy_from_guest(pcidevs, xdsr->pcidevs, > > + > xdsr->num_pcidevs*sizeof(*pcidevs)) ) > > + { > > + xfree(pcidevs); > > + rcu_unlock_domain(d); > > + return -EFAULT; > > + } > > + } > > + > > + d->arch.hvm_domain.pcidevs = pcidevs; > > If the operation gets issued more than once for a given domain, > you're leaking the old pointer here. Overall should think a bit > more about this multiple use case (or outright disallow it).
from current discussion let's outright disallow it. the information should be ready early enough before populating p2m. Thanks Kevin _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
