On Wed, 26 Nov 2014, Andrew Cooper wrote:
On 26/11/2014 20:51, M A Young wrote:--- xen-4.5.0-rc1/tools/libxl/xl_cmdimpl.c.orig 2014-10-24 15:22:40.000000000 +0100 +++ xen-4.5.0-rc1/tools/libxl/xl_cmdimpl.c 2014-11-25 20:29:06.723856433 +000 0 @@ -383,7 +383,7 @@ Sadly, changing printf_info() like this has an unintended knock-on effect to create_domain() (xl create, migrate-recevive, restore) and xl config-update. I think you might have to pass FILE pointers all the way through.
Yes, I had missed the second use of printf_info() . I will post a revised patch shortly.
- puts(buf); + fputs(buf,stderr); puts() and fputs() are not quite synonymous. puts() will unconditionally add an extra newline to stdout. It is unclear whether the string from yajl_gen_get_buf() comes with a trailing newline or not. If the output looks ok, it probably is fine.
It looked okay in my testing. Michael Young
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel