>>> On 21.11.14 at 16:06, <wei.l...@citrix.com> wrote: > --- a/tools/firmware/hvmloader/acpi/build.c > +++ b/tools/firmware/hvmloader/acpi/build.c > @@ -263,6 +263,38 @@ static struct acpi_20_srat *construct_srat(void) > return srat; > } > > +static struct acpi_20_slit *construct_slit(void) > +{ > + struct acpi_20_slit *slit; > + unsigned int num, size; > + int i; >[...] > + for ( i = 0; i < num; i++ )
How can i be signed here when num is unsigned. Even without the common desire to have variables that can't be negative declared unsigned, inconsistencies like this should be avoided. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel