On Fri, Sep 3, 2010 at 3:04 PM, Kurosu <kur...@free.fr> wrote: > I think most can be included as is, and also improved (in my opinion) a bit, > with the shared thing we discussed: indeed some parts are using > (defined(ANDROID) || defined(MAEMO), so we could just add a WMX_HANDHELD > defined for both.
Agreed. > Is MAEMO a true define made by any build toolchain or a define you made > yourself (first one most probably)? I just made it myself. Toolchain doesn't automatically use any special defines. >> Support for N900 international up/down arrows is a bit hackish, but >> that was the easiest way to do it. > > In that case, I see several more requirements: > - a xml file defining those should be ignored > - the initialization should even be forced somewhere in keyboard.cpp > - the control widget shouldn't even add them to the list of displayed things Reason I made it this way is that using keyboard bindings menu clears all previous bindings. So on startup special controls are read from xml file and when bindings are changed they are "injected" in. Currently anything which is defined in keyboard.cpp is whiped when bindings menu is used. Maybe Keyboard::SetDefaultConfig() could be used? N900 has two different keyboard layouts regarding arrow keys. UK/US version has normal arrow keys[1] and every other version[2] has up/down done via fn key. Previously when it wasn't possible to change keyboard bindings I could just define extra binding in default xml file. [1] http://cellulari.tecnocino.it/wp-galleryo/nokia-n900-rover/nokia_n900_rover.jpg [2] http://www.telefonino.net/new_files/images/global/Nokia-N900-847_44600_1.jpg > Also, nice to see you onboard, because I didn't want to bother you by not > mailing you privately, and that now, the discussion can be in the open. For > now, I'm still replying off-list to our private discussion, but I'm ok to > switch to full disclosure mode if you want that too. :D We can continue our discussion on this list too, no problem. -- Mikko _______________________________________________ Wormux-dev mailing list Wormux-dev@gna.org https://mail.gna.org/listinfo/wormux-dev
